Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-tag searches don't show an associated tag list with results #1218

Open
Hawker2 opened this issue Aug 8, 2024 · 4 comments
Open

Non-tag searches don't show an associated tag list with results #1218

Hawker2 opened this issue Aug 8, 2024 · 4 comments
Labels

Comments

@Hawker2
Copy link

Hawker2 commented Aug 8, 2024

Server Software
about:
title: "MangaBooru"
theme: "danbooru2"
url: "http://manga.[redacted].com/index.php?q="

versions:
shimmie: "2.12.0-alpha-20240804-8a8d78a"
schema: 21
php: "8.2.20"
db: "pgsql PostgreSQL 11.22 on x86_64-pc-linux-musl, compiled by gcc (Alpine 13.2.1_git20231014) 13.2.1 20231014, 64-bit"
os: "Linux ba1f0b4b30b9 6.1.0-23-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.99-1 (2024-07-15) x86_64"
server: "Unit/1.32.1"

extensions:
core: ["admin","alias_editor","bbcode","comment","download","et","ext_manager","four_oh_four","handle_pixel","help_pages","image","index","media","mime","post_lock","post_owner","post_source","post_tags","replace_file","setup","static_files","system","tag_list","upgrade","upload","user","user_config","view"]
extra: ["auto_tagger","autocomplete","bulk_actions","bulk_add_csv","bulk_parent_child","emoticons_list","et_server","favorites","home","pools","post_titles","random_image","random_list","rating","regen_thumb","relationships","tag_categories","tag_tools","tagger_xml"]
handled_mimes: ["image/jpeg","image/gif","image/png","image/webp"]

stats:
images: 308
comments: 0
users: 2

media:
memory_limit: "32MB"
disk_use: "138GB"
disk_total: "197GB"

thumbnails:
engine: "convert"
quality: 75
width: 190
height: 300
scaling: 100
mime: "image/jpeg"

Client Software (please complete the following information)

  • Device: macOS 14.5
  • Browser: Safari 17.5

What steps trigger this bug

  1. Perform a search for a valid tag. Note that on the results page in addition to the thumbnails of the results, there is a list of tags to the left (Danbooru theme, perhaps others) of tags that apply to these results. This can be useful to narrow down a search.
  2. Perform a search from the "Help" page that is not based on a tag (for instance, filesize, rating, parent, ratio, etc).

What did you expect to happen?
I expected the same list of tags that applies to the search results to be shown.

What actually happened?
The search results are shown (as in, a list of post thumbnails), but the tag list to the left side is not shown. I feel like this is either a bug (using an incorrect layout) or an oversight.

@discomrade
Copy link
Contributor

Confirmed on default theme, using non-tag metadata queries in a search will prevent it showing the Refine Search block. It's not a layout issue, the feature currently just looks at tags. (I haven't looked into this code before and it's a non-trivial fix so I personally won't be able to look into this for a while.)

@shish shish added the Feature label Oct 13, 2024
@shish
Copy link
Owner

shish commented Oct 13, 2024

Marking as a feature request since it wasn't intended to work that way and hasn't in the past, but I do see the value in it -- but I'm not sure how it could be done without melting the database server ^^;

@smokiemario
Copy link

Just wanna say, this is also a feature I would be interested in if you did end up finding a way to add it

@Hawker2
Copy link
Author

Hawker2 commented Oct 25, 2024

I feel for you - so often things look simple on the outside and are a nightmare to implement due to hidden constraints. If it's eventually doable then I'd love to see it, but also totally understand that this isn't the simple thing I thought it would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants