Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 8 #447

Open
mabdulk opened this issue Nov 19, 2019 · 2 comments
Open

Angular 8 #447

mabdulk opened this issue Nov 19, 2019 · 2 comments

Comments

@mabdulk
Copy link

mabdulk commented Nov 19, 2019

IMPORTANT: Please provide a sample using: http://plnkr.co/edit/lV7zsw7Yqossgs9JOfQU?p=preview

  • I'm submitting a ...
    [ x] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository

  • Do you want to request a feature or report a bug?
    Both. so i'm wondering if ngx-modialog still works with angular 8. i attempted to get it working, everything seems to be working find except one issue that i'm facing.

  • What is the current behavior?
    NullInjectorError: No provider for Modal$$1!
    a NullInjectorError due to the dependency injection not working properly in the constructor declaration of modal (public modal: Modal)

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
    https://plnkr.co or similar (you can use one of the templates above as a starting point).

  1. set up ngx-modialog
  2. declare public modal: Modal in the constructor of the desired component
  3. ng serve
  • What is the expected behavior?
    the code will compile with no errors

  • Please tell us about your environment:

  • Angular version: angular 8
  • Browser: [Chrome 78.0.3904.108]

image

@nguyenbathanh
Copy link

It works with Angular 8.

@samucapuc
Copy link

I have the same problem, what is the solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants