This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Handle rogue carriage returns #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that everything blows up when we have \r without a followup \n in a file. Nokogiri will handle it and give you a new line, but we didn't and so we ended up with nokogiri telling you something was on line 61 and us not having the newline character and the thing being on line 60. Fixes #528 Fixes #545
charlespwd
force-pushed
the
fix/545-rogue-carriage-return
branch
from
b1b32fd
to
9f1b65c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that everything blows up when we have \r without a followup \n in a file. Nokogiri will handle it and give you a new line, but we didn't and so we ended up with nokogiri telling you something was on line 61 and us not having the newline character and the thing being on line 60.
Fixes #528
Fixes #545