Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Fix UnusedAssign false positives from {% render ... with var %} #608

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Fix UnusedAssign false positives from {% render ... with var %} #608

merged 1 commit into from
Jul 19, 2022

Conversation

charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Jul 18, 2022 •
edited
Loading

Fixes #582

Echo of Shopify/liquid#1596 in our SFR port.

@charlespwd charlespwd requested a review from a team July 18, 2022 12:30
karreiro
karreiro approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @charlespwd!

@charlespwd charlespwd merged commit 7838c83 into main Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karreiro karreiro karreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnusedAssign reported when using "with" for render
2 participants
@charlespwd @karreiro