This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Prevent server from hanging on error #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, sometimes $stderr.puts err.full_message hangs. And I mean the word used, it _hangs_. It doesn't raise an error. This is annoying because you end up with a 100% CPU situation instead of logging the error you're meaning to log. This PR wraps the error printing into timeouts so that they print and stop hanging. (What bullshit...) Fixes #622
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, sometimes $stderr.puts err.full_message hangs. And I mean the word used, it hangs. It doesn't raise an error. This is annoying because you end up with a 100% CPU instead of logging the error you're meaning to handle.
This PR wraps the error printing into timeouts so that they print and stop hanging.
Super ironic.
Fixes #622