Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Showdown compatible with Broswerify #108

Closed
wants to merge 1 commit into from

Conversation

mattsmith14
Copy link

Browserify implements a subset of the fs module, so the current check passes, but it does not support readdirSync, so that call fails.

Browserify implements a subset of the fs module, so the current check passes, but it does not support readdirSync, so that call fails.
@Miramac
Copy link

Miramac commented Dec 8, 2014

👍

compatibility with Browserify would be awesome!

@tivie tivie self-assigned this Dec 11, 2014
@tivie
Copy link
Member

tivie commented Dec 11, 2014

I will look into it as soon as possible.

@mattsmith14
Copy link
Author

Sounds good. There are probably 4 other pull requests that attempt to fix the same/similar issues. This one is just a super simple check the fs has the method we are trying to use.

@tivie
Copy link
Member

tivie commented Dec 11, 2014

@varfoo yes. We are restructuring showdown. Since we'll probably move each
extension to its own repository, there will be no reason to call fs.

Regardless, the ideal way to approach the problem is abstracting the
library from the platform it's running on, in a similar fashion to
underscore.js method. This will make it compatible with node and browser
out of the box and, consequently, compatible with browserify. It will also
be easier to make the lib compatible with AMD and commonjs.


Estevão Soares dos Santos


2014-12-11 17:33 GMT+00:00 varfoo [email protected]:

Sounds good. There are probably 4 other pull requests that attempt to fix
the same/similar issues. This one is just a super simple check the fs has
the method we are trying to use.


Reply to this email directly or view it on GitHub
#108 (comment).

@mattsmith14
Copy link
Author

@tivie sounds great! Thanks for stepping up and managing this, it seems like you have a lot of work on your plate.

@tivie
Copy link
Member

tivie commented Jan 5, 2015

#50

@tivie
Copy link
Member

tivie commented Jan 16, 2015

Please have a look at eae5f0e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants