Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APNG not supported #79

Closed
javiergutierrezchamorro opened this issue Aug 7, 2017 · 15 comments
Closed

APNG not supported #79

javiergutierrezchamorro opened this issue Aug 7, 2017 · 15 comments
Assignees
Labels
I-High Issues that are breaking core functionality for a small number of users T-Feature Requests for a new feature to be added T-Needs Tests

Comments

@javiergutierrezchamorro
Copy link

With old OptiPNG I could use -protect acTL,fcTL,fdAT to keep APNG animations. But seems it is not possible with OxiPNG.

Find attached example.

Will you support it?

animated_png_example_bouncing_beach_ball

@shssoichiro
Copy link
Owner

I do plan to implement support for APNG files in Oxipng, however at the moment it is low priority so I can't give a timeframe on when it will be implemented.

@shssoichiro shssoichiro added the T-Feature Requests for a new feature to be added label Aug 7, 2017
@javiergutierrezchamorro
Copy link
Author

Thanks.
Once implemented, I will include it in FileOptimizer replacing OptiPNG:
http://nikkhokkho.sourceforge.net/static.php?page=FileOptimizer

@shssoichiro shssoichiro added I-Medium Issues that are breaking core functionality, but have a known workaround T-Needs Tests labels Aug 8, 2017
@shssoichiro shssoichiro added I-High Issues that are breaking core functionality for a small number of users and removed I-Medium Issues that are breaking core functionality, but have a known workaround labels Feb 1, 2018
@shssoichiro shssoichiro self-assigned this Feb 1, 2018
@TPS
Copy link

TPS commented Apr 10, 2018

N.B.: 1st work on this is @ db0131c

@shssoichiro
Copy link
Owner

I just wanted to reassure everyone that I am still working on this issue. I have had less time lately to focus on open source, but I have not abandoned this project.

@javiergutierrezchamorro
Copy link
Author

Glasd to hear @shssoichiro

@shssoichiro
Copy link
Owner

Unfortunately this is soft-blocked on image-rs/image#195. The code in oxipng can still be written, but there would be no sanity check on optimized images to make sure oxipng hasn't corrupted them, and no automated tests. I don't feel comfortable delivering this functionality until its correctness can be verified.

@shssoichiro shssoichiro added the T-Blocked External This issue cannot be fixed until something is changed by a third-party label Oct 12, 2018
@shssoichiro shssoichiro changed the title APNG not supoorted APNG not supported Oct 12, 2018
@AlexApps99
Copy link

APNG support was added in image-rs/image#1250, so it's now possible to resume development of this feature.

@shssoichiro shssoichiro removed the T-Blocked External This issue cannot be fixed until something is changed by a third-party label Aug 11, 2020
@javiergutierrezchamorro
Copy link
Author

Just tried with latest 5.0.0 and reports as not supported yet.

image

@javiergutierrezchamorro
Copy link
Author

Any progress on this?

@TPS
Copy link

TPS commented May 4, 2023

@shssoichiro, @andrews05: Sorry for tagging y'all directly 🙇🏾‍♂️, but minimal support seems so close. If y'all could spare a few minutes & let us know whether this is a reasonable idea, we'd appreciate it.:

With old OptiPNG I could use -protect acTL,fcTL,fdAT to keep APNG animations. But seems it is not possible with OxiPNG.

Is it possible, in the interim, to have some way of protecting just these chunks? IIUC, that would salvage APNGs enough that they could be otherwised optimized by OxiPNG, until full support can be finalized.

@andrews05
Copy link
Collaborator

@TPS yeah, if #417 gets resolved then we should at least be able to preserve those chunks without simply aborting. I am hoping to solve that issue, so I'll keep this one in mind when looking at it.

@TPS
Copy link

TPS commented May 5, 2023

@andrews05 Thanks very much 🙇🏾‍♂️

@andrews05
Copy link
Collaborator

@TPS Turns out this isn't quite so simple. The APNG fdAT chunks use the same depth, colour type, palette, interlacing, etc as the main image. If those values are changed at all during optimisation, the fdATs would then be invalid. So it isn't just a matter of preserving those chunks, you would also have to disable all reductions.
If the only possible action then is recompressing the first frame with no reductions, the savings would be very minimal. It may be best to leave this until full support can be implemented.

@TPS
Copy link

TPS commented May 12, 2023

We really appreciate you taking the time to research & explain this, @andrews05 🙇🏾‍♂️

@TPS
Copy link

TPS commented Aug 21, 2023

#551 tracks Full aPNG Optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-High Issues that are breaking core functionality for a small number of users T-Feature Requests for a new feature to be added T-Needs Tests
Projects
None yet
Development

No branches or pull requests

5 participants