Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the structure of Match #36

Open
ThomasdenH opened this issue Jan 16, 2020 · 0 comments
Open

Change the structure of Match #36

ThomasdenH opened this issue Jan 16, 2020 · 0 comments
Labels
breaking

Comments

@ThomasdenH
Copy link
Contributor

I think Match could be improved in the following way:

  • i and j currently indicate character positions. Instead, I think it would be better to replace them by a range that instead can be used to slice the string, i.e. changing them to byte indexes.
  • guesses is always set in the public API. For that reason I think the publicly exposed type should not use an Option for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThomasdenH @shssoichiro