Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider taking &[AsRef<str>] in zxcvbn user input #87

Open
felinira opened this issue Aug 25, 2024 · 0 comments
Open

Consider taking &[AsRef<str>] in zxcvbn user input #87

felinira opened this issue Aug 25, 2024 · 0 comments

Comments

@felinira
Copy link

Otherwise passing a Vec<String> requires iterating over every value, allocating a new Vec that borrows from the previous, passing that, then discarding the Vec. Alternatively one can only leak the value.

This change should be backwards compatible, as &str implements AsRef<str>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant