Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow jabba exec JAVA_VERSION COMMAND #285

Open
ketan opened this issue Sep 16, 2018 · 2 comments · May be fixed by #289
Open

Allow jabba exec JAVA_VERSION COMMAND #285

ketan opened this issue Sep 16, 2018 · 2 comments · May be fixed by #289

Comments

@ketan
Copy link

ketan commented Sep 16, 2018

Hi,

I'd like to see if it makes sense to contribute a jabba exec command to allow executing one-shot commands without a jabba use before.

I'm happy to take a stay at contributing this if you feel this is something that might be useful in general.

Thanks.
@shyiko
Copy link
Owner

shyiko commented Sep 16, 2018

Hi @ketan.

Good idea. I can easily see how it can be useful for things like
jabba exec 1.10 jshell, etc.

PR is more than welcome.

ketan added a commit to ketan/jabba that referenced this issue Sep 18, 2018
@ketan
Added support for jabba exec.
a196cc5 
Refactored `use` command to improve usability by introducing a `GetVars`
function that returns the functions to be exported for use by `exec`.

Implemented an `exec` that simply passes the args as-is to the specified
binary via `syscall.Exec`.

Fixes shyiko#285
@ketan ketan linked a pull request Sep 18, 2018 that will close this issue
Open
@nicerloop
Copy link

see https://github.com/nicerloop/jabba-wrapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for jabba exec. ketan/jabba
3 participants
@ketan @shyiko @nicerloop