Skip to content

Commit

Permalink
fix: allow extra kernel args for secureboot installer
Browse files Browse the repository at this point in the history
With SecureBoot, kernel args are part of the UKI (and signed), so we
need to allow kernel args when building an installer, as this is the
only way to allow updating kernel args in SecureBoot mode.

Signed-off-by: Andrey Smirnov <[email protected]>
  • Loading branch information
smira committed Nov 13, 2023
1 parent f38eaaa commit 71a3bf0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/imager/profile/profile.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ func (p *Profile) Validate() error {
return fmt.Errorf("disk size is required for image output")
}
case OutKindInstaller:
if len(p.Customization.ExtraKernelArgs) > 0 {
return fmt.Errorf("customization of kernel args is not supported for %s output", p.Output.Kind)
if !p.SecureBootEnabled() && len(p.Customization.ExtraKernelArgs) > 0 {
return fmt.Errorf("customization of kernel args is not supported for %s output in !secureboot mode", p.Output.Kind)
}

if len(p.Customization.MetaContents) > 0 {
Expand Down

0 comments on commit 71a3bf0

Please sign in to comment.