-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support deno + caching_sha2_password FULL_AUTHENTICATION_PACKET flow #2704
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
=======================================
Coverage 90.32% 90.33%
=======================================
Files 71 71
Lines 15727 15730 +3
Branches 1340 1340
=======================================
+ Hits 14206 14209 +3
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @sidorares, 🙋🏻♂️
Some common Deno conflicts:
The main challenge is normally handling |
Closes #2686
Deno uses default
RSA_PKCS1_PADDING
for publicEncrypt while in node it'sRSA_PKCS1_OAEP_PADDING
by default. As a resultPERFORM_FULL_AUTHENTICATION_PACKET
step returns password encoded differently from what server expects ( note: mysql versions prior to 8.0.5 might expect RSA_PKCS1_PADDING padding, need to validate that and maybe potentially use based on the server? mysql-net/MySqlConnector#489 )