Add pattern and selector to PromisePoolCluster#getConnection

[TuckerWhitehouse]

The implementation of PromisePoolCluster#getConnection does not match the capabilities of PoolCluster#getConnection nor the definition in promise.d.ts.

This change corrects this by adding the missing pattern and selector parameters which are passed through to the underlying method.

Fixes #1381

Note: I may have missed them, but I didn't see any tests for PromisePoolCluster to update or add to with this change.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (ac200fe) to head (0007f0c).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
promise.js	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3017   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files          71       71           
  Lines       12889    12889           
  Branches     1353     1353           
=======================================
  Hits        11360    11360           
  Misses       1529     1529           

Flag	Coverage Δ
compression-0	88.13% <50.00%> (ø)
compression-1	88.13% <50.00%> (ø)
tls-0	87.55% <50.00%> (ø)
tls-1	87.89% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wellwelwel]

Thanks, @TuckerWhitehouse 🙋🏻‍♂️

Just confirming it:

node-mysql2/lib/pool_cluster.js

Lines 165 to 178 in dc3a680

	getConnection(pattern, selector, cb) {
	let namespace;
	if (typeof pattern === 'function') {
	cb = pattern;
	namespace = this.of();
	} else {
	if (typeof selector === 'function') {
	cb = selector;
	selector = this._defaultSelector;
	}
	namespace = this.of(pattern, selector);
	}
	namespace.getConnection(cb);
	}

I need to check if the typings are correct.

[wellwelwel]

LGTM

node-mysql2/promise.d.ts

Lines 112 to 114 in dc3a680

	getConnection(): Promise<PoolConnection>;
	getConnection(group: string): Promise<PoolConnection>;
	getConnection(group: string, selector: string): Promise<PoolConnection>;