Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: impl LongRefFromWasmAbi for T where T: Tsify + FromWasmAbi to use reference as input of async function #34

Open
Pantamis opened this issue Apr 24, 2024 · 0 comments

Comments

@Pantamis
Copy link

Currently we cannot use a reference to a tsify(from_wasm_abi) type in a async function.

This is because reference in async function needs to implement LongRefFromWasmAbi for reasons described in wasm-bindgen#3188 and here

#32 actually showed that the implementation of RefFromWasmAbi before the fix #33 was the correct one for LongRefFromWasmAbi

I plan to do a PR to implement this. This would make values deriving from_wasm_abi universally admissible as input by value or reference of a wasm-bindgen function async or not !

I am working on finding a good test for it and maybe change the documentation to feature all the nice things tsify-next provides 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant