New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone back button does not close receipt #221

Open

generalpiston opened this issue Mar 6, 2019 · 1 comment

Assignees

Labels

bug

Milestone

Collaborator

generalpiston commented Mar 6, 2019 •

edited

Loading

When the phone's back button is tapped, any modal should be closed. This is currently not happening and probably causing a few crashes. To reproduce:

Trade -> ZRX -> Buy -> Fill -> Any amount -> Receipt
Tap phone back button
Any amount -> Receipt
Hit "Cancel"

generalpiston added the bug label

generalpiston added this to the 0.9.5 milestone

generalpiston self-assigned this

generalpiston modified the milestones: 0.9.5, 0.9.6, 0.9.7

Collaborator Author

generalpiston commented Apr 20, 2019

Should check with react-native-navigation.

generalpiston modified the milestones: 0.9.7, 0.9.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment