From 0c4318bfab761e79b6a87f83f8f0e51bf725b700 Mon Sep 17 00:00:00 2001 From: Ryan Fitzpatrick Date: Fri, 16 Jul 2021 17:16:54 +0000 Subject: [PATCH] go fmt and vet fix --- pkg/core/writer/signalfx/writer_test.go | 6 ++++-- .../elasticsearch/query/datapoints_test.go | 12 ++++++------ .../elasticsearch/query/response_test.go | 16 ++++++++-------- 3 files changed, 18 insertions(+), 16 deletions(-) diff --git a/pkg/core/writer/signalfx/writer_test.go b/pkg/core/writer/signalfx/writer_test.go index cdd0dd6a7e..e73e24de61 100644 --- a/pkg/core/writer/signalfx/writer_test.go +++ b/pkg/core/writer/signalfx/writer_test.go @@ -62,7 +62,7 @@ func TestIsTransientError(t *testing.T) { notTemporary := tempError{func() bool { return false }} wrappedNotTemporary := fmt.Errorf("%w", notTemporary) - for _, test := range []struct { + tests := []struct { name string err error expected bool @@ -81,7 +81,9 @@ func TestIsTransientError(t *testing.T) { {"not temporary error", notTemporary, false}, {"wrapped not temporary error", wrappedNotTemporary, false}, {"doubly wrapped not temporary error", fmt.Errorf("%w", wrappedNotTemporary), false}, - } { + } + for i := range tests { + test := tests[i] t.Run(test.name, func(tt *testing.T) { require.Equal(tt, test.expected, isTransientError(test.err)) }) diff --git a/pkg/monitors/elasticsearch/query/datapoints_test.go b/pkg/monitors/elasticsearch/query/datapoints_test.go index e46223ce98..9cc3b098e8 100644 --- a/pkg/monitors/elasticsearch/query/datapoints_test.go +++ b/pkg/monitors/elasticsearch/query/datapoints_test.go @@ -139,7 +139,7 @@ func TestExtendedStatsAggregationsFromFiltersAggregation(t *testing.T) { "max": 100.0, "avg": 50.14530580444098, "sum": 257446.0, - "sum_of_squares": 1.7184548E7, + "sum_of_squares": 1.7184548e7, "variance": 832.6528246727477, "std_deviation": 28.855724296450223, "std_deviation_bounds": map[string]interface{}{ @@ -162,7 +162,7 @@ func TestExtendedStatsAggregationsFromFiltersAggregation(t *testing.T) { "max": 100.0, "avg": 50.03486560186989, "sum": 256879.0, - "sum_of_squares": 1.7288541E7, + "sum_of_squares": 1.7288541e7, "variance": 863.9724891034797, "std_deviation": 29.39340893981982, "std_deviation_bounds": map[string]interface{}{ @@ -232,7 +232,7 @@ func TestExtendedStatsAggregationsFromFiltersAggregation(t *testing.T) { { Metric: "metric_agg_1.sum_of_squares", Dimensions: dims["madrid"], - Value: datapoint.NewFloatValue(1.7288541E7), + Value: datapoint.NewFloatValue(1.7288541e7), MetricType: datapoint.Gauge, }, { @@ -292,7 +292,7 @@ func TestExtendedStatsAggregationsFromFiltersAggregation(t *testing.T) { { Metric: "metric_agg_1.sum_of_squares", Dimensions: dims["nairobi"], - Value: datapoint.NewFloatValue(1.7184548E7), + Value: datapoint.NewFloatValue(1.7184548e7), MetricType: datapoint.Gauge, }, { @@ -455,7 +455,7 @@ func TestMultipleMetricAggregationWithTermsAggregation(t *testing.T) { "max": 100.0, "avg": 50.14530580444098, "sum": 257446.0, - "sum_of_squares": 1.7184548E7, + "sum_of_squares": 1.7184548e7, "variance": 832.6528246727477, "std_deviation": 28.855724296450223, "std_deviation_bounds": map[string]interface{}{ @@ -559,7 +559,7 @@ func TestMultipleMetricAggregationWithTermsAggregation(t *testing.T) { { Metric: "metric_agg_3.sum_of_squares", Dimensions: dims["metric_agg_3"], - Value: datapoint.NewFloatValue(1.7184548E7), + Value: datapoint.NewFloatValue(1.7184548e7), MetricType: datapoint.Gauge, }, { diff --git a/pkg/monitors/elasticsearch/query/response_test.go b/pkg/monitors/elasticsearch/query/response_test.go index cd348ea704..188596ad49 100644 --- a/pkg/monitors/elasticsearch/query/response_test.go +++ b/pkg/monitors/elasticsearch/query/response_test.go @@ -601,7 +601,7 @@ func getSimpleMultiValueAggregationTestContexts() ([]*testContext, *errors.Error "max": 100.0, "avg": 49.27212287941311, "sum": 214925.0, - "sum_of_squares": 1.4335299E7, + "sum_of_squares": 1.4335299e7, "variance": 858.662996364543, "std_deviation": 29.302952007682485, "std_deviation_bounds": map[string]interface{}{ @@ -624,7 +624,7 @@ func getSimpleMultiValueAggregationTestContexts() ([]*testContext, *errors.Error "max": 100.0, "avg": 50.197615772581386, "sum": 218962.0, - "sum_of_squares": 1.4644106E7, + "sum_of_squares": 1.4644106e7, "variance": 837.3992790472341, "std_deviation": 28.93785201163407, "std_deviation_bounds": map[string]interface{}{ @@ -820,7 +820,7 @@ func getMultipleMetricAggregationTestContexts() ([]*testContext, *errors.Error) "max": 100.0, "avg": 50.14530580444098, "sum": 257446.0, - "sum_of_squares": 1.7184548E7, + "sum_of_squares": 1.7184548e7, "variance": 832.6528246727477, "std_deviation": 28.855724296450223, "std_deviation_bounds": map[string]interface{}{ @@ -861,7 +861,7 @@ func getMultipleMetricAggregationTestContexts() ([]*testContext, *errors.Error) "max": 100.0, "avg": 50.03486560186989, "sum": 256879.0, - "sum_of_squares": 1.7288541E7, + "sum_of_squares": 1.7288541e7, "variance": 863.9724891034797, "std_deviation": 29.39340893981982, "std_deviation_bounds": map[string]interface{}{ @@ -902,7 +902,7 @@ func getMultipleMetricAggregationTestContexts() ([]*testContext, *errors.Error) "max": 100.0, "avg": 49.577522399688355, "sum": 254531.0, - "sum_of_squares": 1.7057901E7, + "sum_of_squares": 1.7057901e7, "variance": 864.6055017695604, "std_deviation": 29.40417490373706, "std_deviation_bounds": map[string]interface{}{ @@ -943,7 +943,7 @@ func getMultipleMetricAggregationTestContexts() ([]*testContext, *errors.Error) "max": 100.0, "avg": 49.273081417997666, "sum": 252968.0, - "sum_of_squares": 1.6862378E7, + "sum_of_squares": 1.6862378e7, "variance": 856.6157265001883, "std_deviation": 29.267998334361515, "std_deviation_bounds": map[string]interface{}{ @@ -994,7 +994,7 @@ func getMultipleMetricAggregationTestContexts() ([]*testContext, *errors.Error) "max": 100.0, "avg": 50.084047707789786, "sum": 268751.0, - "sum_of_squares": 1.7938575E7, + "sum_of_squares": 1.7938575e7, "variance": 834.5950604703294, "std_deviation": 28.889358948760517, "std_deviation_bounds": map[string]interface{}{ @@ -1035,7 +1035,7 @@ func getMultipleMetricAggregationTestContexts() ([]*testContext, *errors.Error) "max": 100.0, "avg": 49.27953783078643, "sum": 264434.0, - "sum_of_squares": 1.7629144E7, + "sum_of_squares": 1.7629144e7, "variance": 856.8689327718637, "std_deviation": 29.27232366539875, "std_deviation_bounds": map[string]interface{}{