Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder style decisions #11

Closed
jkwatson opened this issue May 18, 2021 · 1 comment
Closed

Builder style decisions #11

jkwatson opened this issue May 18, 2021 · 1 comment

Comments

@jkwatson
Copy link
Contributor

jkwatson commented May 18, 2021 •
edited
Loading

3 builder-related style questions:

  1. .newBuilder() vs .builder() for creating the builder.
  2. .setFoo(foo) vs .withFoo(foo) vs. .foo(foo)
  3. Should required fields be included on the builder creational method, or enforced at build() time?
@jkwatson jkwatson mentioned this issue May 18, 2021
Merged
@mateuszrzeszutek
Copy link
Contributor

Done in #342 I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkwatson @mateuszrzeszutek