-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fips: otelcol images for linux and windows #5384
Conversation
79edb47
to
146043a
Compare
e1e9dc6
to
3313cb2
Compare
146043a
to
4ea0804
Compare
3313cb2
to
cbac824
Compare
4ea0804
to
9e03c75
Compare
cbac824
to
2ce51cc
Compare
2ce51cc
to
d35b5a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking merge but there's some code smells imo
OTELCOL_DIR="${OTELCOL_DIR}/fips" | ||
DIST_DIR="${OTELCOL_DIR}/dist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe we should bring down the instantiation for the non-fips setting of these variables to live in the "true" conditional block?
if [ ! -f "${REPO_DIR}/dist/agent-bundle_linux_${arch}.tar.gz" ]; then | ||
echo "${REPO_DIR}/dist/agent-bundle_linux_${arch}.tar.gz not found!" >&2 | ||
exit 1 | ||
if [ ! -f "${REPO_DIR}/dist/agent-bundle_linux_${arch}.tar.gz" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this PR, but does this mean if we set SKIP_BUNDLE="true"
, the build will fail due to this line? (given FIPS!="true"
)
It's hard to know if the nested IF statements are intentionally noop
ing the uncovered else case or if it's just because we didn't want to if [STATEMENT_A] && [STATEMENT_B]
the conditional in the parent if block... I'm starting to think it's the latter?
Thanks for review James. There is more to do but if this passes muster, I'm happy to merge it and we can work on this more. There are still TODOs listed in the PR description that will require us to review further. |
smartagent
componentsquay.io/signalfx/splunk-otel-collector-fips:<version>
. Thelatest
tag would be available.quay.io/signalfx/splunk-otel-collector:<version>-fips
. Thelatest
tag would be unavailable since they are reserved for the non-fips manifests.