-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ballast extension entirely from components. #5429
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more reference that needs removed here:
"memory_ballast", |
We also have some env var magic around the ballast extension that we need to clean up |
Looks good to me. While there's still some references to the ballast, it's mostly in testdata or readmes, or for backwards compatibility
|
We probably need this test to be passing as well |
Description:
Remove the deprecated memory ballast extension from bundled components, which was replaced by GOMEMLIMIT