Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimulationRunner::configure_and_build() has redundant optimized parameter #74

Open
Thecave3 opened this issue May 14, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@Thecave3
Copy link
Collaborator

The optimized parameter in SimulationRunner::configure_and_build() is redundant since it is already a class parameter.

sem/sem/runner.py

Lines 135 to 136 in a6c5b29

def configure_and_build(self, show_progress=True, optimized=True,
skip_configuration=False):

The suggested action is to remove this parameter from the signature and to change the following usage in self.optimized:

if optimized:

@Thecave3 Thecave3 added enhancement New feature or request invalid This doesn't seem right labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants