From 551b0390cc56c6647eaaf77202d7cc1fe8ef1964 Mon Sep 17 00:00:00 2001 From: Marco Franssen Date: Fri, 11 Oct 2024 10:17:53 +0200 Subject: [PATCH] Fix copy --only for signatures + update/align docs See https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/copy/copy.go#L192 requires to have value `sig` instead of `sign`. Also aligned the option docs order to align with the order of the example. https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/copy.go#L40 --- cmd/cosign/cli/copy/copy.go | 2 +- cmd/cosign/cli/options/copy.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/cosign/cli/copy/copy.go b/cmd/cosign/cli/copy/copy.go index 6575c71fb4be..7e506f13bedd 100644 --- a/cmd/cosign/cli/copy/copy.go +++ b/cmd/cosign/cli/copy/copy.go @@ -186,7 +186,7 @@ func parseOnlyOpt(onlyFlag string, sigOnly bool) []tagMap { if sigOnly { fmt.Fprintf(os.Stderr, "--sig-only is deprecated, use --only=sig instead") - tagSet.Insert("sign") + tagSet.Insert("sig") } if tagSet.Has("sig") { diff --git a/cmd/cosign/cli/options/copy.go b/cmd/cosign/cli/options/copy.go index 7f4d5f373caf..940818637154 100644 --- a/cmd/cosign/cli/options/copy.go +++ b/cmd/cosign/cli/options/copy.go @@ -35,7 +35,7 @@ func (o *CopyOptions) AddFlags(cmd *cobra.Command) { o.Registry.AddFlags(cmd) cmd.Flags().StringVar(&o.CopyOnly, "only", "", - "custom string array to only copy specific items, this flag is comma delimited. ex: --only=sbom,sign,att") + "custom string array to only copy specific items, this flag is comma delimited. ex: --only=sig,att,sbom") cmd.Flags().BoolVar(&o.SignatureOnly, "sig-only", false, "[DEPRECATED] only copy the image signature")