Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the user to specify which socket to use for Spiffe #1420

Closed
vaikas opened this issue Feb 7, 2022 · 0 comments · Fixed by #1421
Closed

Allow the user to specify which socket to use for Spiffe #1420

vaikas opened this issue Feb 7, 2022 · 0 comments · Fixed by #1421
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Contributor

vaikas commented Feb 7, 2022

Description

Currently the socket is hardcoded in the Spiffe provider. Depending on the deployment / configuration of Spire agent, this may change, so it should be configurable.
Looks like the intent was always to make it configurable.

https://github.com/sigstore/cosign/pull/1220/files#diff-127f11cd4bca4813a998988cc0859e8f81be2069104a818667d9a92f276d2c3eR53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to override the Spiffe socket via environmental variable: vaikas/cosign
1 participant
@vaikas