Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support format specific suffixes mediaTypes for the SBOM files in both cyclonedx and spdx #1604

Closed
developer-guy opened this issue Mar 14, 2022 · 2 comments · Fixed by #1663
Labels
enhancement New feature or request

Comments

@developer-guy
Copy link
Member

Description

There is no direct support for specifying an SPDX file in a JSON format via mediaTypes in cosign. In SBOM_SPEC, we said that there are format-specific suffixes supported by cosign, but seems we missed adding that support.

Once we grab the file via flag --sbom while attaching it, we'll be looking at the format of the file to detect that is it in format XML, JSON, or SPDX, then we determine its mediaType according to that. For example, if it is an SPDX file we'll be using text/spdx, if it is an SPDX file in the form of JSON, we'll be using text/spdx+json.

WDYT @dlorenc @cpanato @Dentrax?

@developer-guy developer-guy added the enhancement New feature or request label Mar 14, 2022
@dlorenc
Copy link
Member

dlorenc commented Mar 14, 2022

Ah, sgtm

@hectorj2f
Copy link
Contributor

I need to identify the specific format of the media types. So I created a PR #1663 to add support for the input-format. Let me know what you think about it 👍🏻 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants