Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golangci-lint issues in the test/ directory #3760

Closed
dmitris opened this issue Jul 2, 2024 · 4 comments · Fixed by #3765
Closed

fix golangci-lint issues in the test/ directory #3760

dmitris opened this issue Jul 2, 2024 · 4 comments · Fixed by #3765
Assignees
Labels
enhancement New feature or request

Comments

@dmitris
Copy link
Contributor

dmitris commented Jul 2, 2024

Description

Current golangci-lint issues from golangci-lint run --build-tags e2e ./test: https://gist.github.com/dmitris/5b43918c553946a3b77247622d63e277
need to fix at least some of them - those that are "reasonable" to fix (ex. I would pass on the errcheck issues - "Error return value of [...] is not checked".

@dmitris dmitris added the enhancement New feature or request label Jul 2, 2024
@cpanato cpanato self-assigned this Jul 2, 2024
@cpanato
Copy link
Member

cpanato commented Jul 2, 2024

thanks, i will work on those, maybe we can also enable this to run on ci

@dmitris
Copy link
Contributor Author

dmitris commented Jul 2, 2024

for CI, it would be good to add a .golangci.yml file and disable there the "noisy" linters (such as errcheck) which we don't want to enforce.

@cpanato
Copy link
Member

cpanato commented Jul 2, 2024

i think we want the errcheck even if that is kind noisy

@dmitris
Copy link
Contributor Author

dmitris commented Jul 2, 2024

i think we want the errcheck even if that is kind noisy

but then we wouldn't be able to break the builds on new golangci-lint issues, right? Unless we either fix or //nolint:errcheck the "preexisting conditions"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants