Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop optional from common.PublicKey.raw_bytes #325

Open
woodruffw opened this issue May 13, 2024 · 0 comments · May be fixed by #326
Open

Drop optional from common.PublicKey.raw_bytes #325

woodruffw opened this issue May 13, 2024 · 0 comments · May be fixed by #326
Assignees

Comments

@woodruffw
Copy link
Member

In practice, the PublicKey message is used in settings that require direct access to the raw_bytes, with the assumption that it isn't missing.

message PublicKey {
// DER-encoded public key, encoding method is specified by the
// key_details attribute.
optional bytes raw_bytes = 1;
// Key encoding and signature algorithm to use for this key.
PublicKeyDetails key_details = 2;
// Optional validity period for this key, *inclusive* of the endpoints.
optional TimeRange valid_for = 3;
}

We should be able to drop the optional qualifier here without causing any real breakage -- proto3 is still implicitly optional everywhere, so dropping optional will just refine the type hints.

@woodruffw woodruffw self-assigned this May 13, 2024
@woodruffw woodruffw linked a pull request May 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant