Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a mock NTP client for testing. #148

Closed
kommendorkapten opened this issue Nov 15, 2022 · 0 comments · Fixed by #217
Closed

Implement a mock NTP client for testing. #148

kommendorkapten opened this issue Nov 15, 2022 · 0 comments · Fixed by #217
Assignees
@malancas
Labels
enhancement New feature or request p1 P1 Priority Task

Comments

@kommendorkapten
Copy link
Member

Description

Getting unit tests for the ntp monitoring is non-complete as of now. By implementing an interface that captures the ntp client's functions, we can rely on dependency injection during unit test to get the monitoring part tested. This functionality does not yet exist, but proposed as of this PR #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malancas malancas

Labels
enhancement New feature or request p1 P1 Priority Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mock NTP client malancas/timestamp-authority
3 participants
@haydentherapper @kommendorkapten @malancas