fix: remove requirement for operationId #69
Conversation
|
Should hopefully solve external-secrets/kubernetes-external-secrets#278 :) |
| } : { | ||
| pathName: options.pathname, | ||
| method: options.method | ||
| } |
There was a problem hiding this comment.
According to https://github.com/swagger-api/swagger-js#tryitout-executor
pathName and method can be provided in place of operationId
Possibly even preferred in this case?
// If
pathNameandmethod, then those are used instead of operationId. This is useful if you're using this dynamically, aspathName+methodare guarenteed to be unique.
Keeping old behaviour when possible seemed like a less intrusive change tho :)
| @@ -220,7 +220,6 @@ class Component { | |||
| // "Expose" operations by omitting the leading _ from the method name. | |||
| // | |||
| Object.keys(endpoint.pathItem) | |||
| .filter(key => endpoint.pathItem[key].operationId) | |||
There was a problem hiding this comment.
So I'm not really sure why this filter existed in the first place but it seems fine to remove?
|
I suppose alternative solution would be to make sure nothing is generated for paths lacking operationId or do patching in https://github.com/godaddy/kubernetes-client/blob/0f9ec26b381c8603e7727c3346edb35e1db2deb1/lib/swagger-client.js#L80-L107 which expects an item to be callable if it has the methods |
No description provided.