Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of fprintf instead of GREATEST_FPRINTF #117

Open
Nicolapps opened this issue Feb 11, 2023 · 2 comments
Open

Usage of fprintf instead of GREATEST_FPRINTF #117

Nicolapps opened this issue Feb 11, 2023 · 2 comments
Assignees
@silentbicycle
Labels
bug
Milestone
1.5.1

Comments

@Nicolapps
Copy link

On lines 761 and 1119 of greatest.h, fprintf is used. Shouldn’t GREATEST_FPRINTF be used instead, to allow the usage of the library in cases where fprintf isn’t available and the user would like to use another function instead?

greatest/greatest.h

Line 761 in 11a6af1

fprintf(stderr, "Error: Test run inside another test.\n"); \

greatest/greatest.h

Line 1119 in 11a6af1

fprintf(stderr, "init_second_pass: a %lu, c %lu, state %lu\n", \

@silentbicycle
Copy link
Owner

Good catch, thanks. These will be fixed in the next release, and I'll check if any others got missed.

@silentbicycle silentbicycle added this to the 1.5.1 milestone Feb 14, 2023
@silentbicycle silentbicycle self-assigned this Feb 14, 2023
@Nicolapps
Copy link
Author

Thank you for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silentbicycle silentbicycle

Labels
bug
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
2 participants
@silentbicycle @Nicolapps