Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull fwdata model version from repo #1022

Closed
hahn-kev opened this issue Aug 8, 2024 · 4 comments · Fixed by #1082
Closed

Pull fwdata model version from repo #1022

hahn-kev opened this issue Aug 8, 2024 · 4 comments · Fixed by #1082
Assignees

Comments

@hahn-kev
Copy link
Collaborator

hahn-kev commented Aug 8, 2024

Describe the feature
Just like we pull in the writing systems and project id, it would be useful to know the model version.

Who is this feature for?
Users of FW lite who might want to sync a project from lexbox

Pages affected
Project page maybe.

@rmunn
Copy link
Contributor

rmunn commented Aug 9, 2024

This one will be easy: any FLEx project will have a FLExProject.ModelVersion file at the root of the repo. It's a simple JSON file containing just one property, modelversion, e.g.:

{"modelversion": 7000068}

I wouldn't put this on the project page as it's highly-technical info and most users won't even know what it means. Maybe in an "Advanced" section that you have to click to reveal.

@rmunn
Copy link
Contributor

rmunn commented Aug 9, 2024

Note that LfMerge used to handle model versions of 68 or higher, but it now handles only version 72 (technically 7000072) or higher (which is the current model version as of FLEx 9.0). So anything with model version 68, 69, or 70 is FLEx 8.x (model version 71 was never released). LfMerge never supported model versions earlier than 68.

@rmunn
Copy link
Contributor

rmunn commented Aug 9, 2024

LfMerge would probably benefit from a LexBox API that exposes the model number of a project (see sillsdev/LfMerge#343 for details). So this is worth doing so that LfMerge can improve its behavior.

@rmunn
Copy link
Contributor

rmunn commented Sep 27, 2024

Update: Decided today that frontend should present this as a FW version, e.g. 8.2 or 8.3 or 9.x. Will keep a haradcoded mapping on frontend, updating it on the rare occasion that FW adds a new model version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants