Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: LfMerge errors not making it to the UI #1303

Closed
longrunningprocess opened this issue Feb 9, 2022 · 5 comments
Closed

bug: LfMerge errors not making it to the UI #1303

longrunningprocess opened this issue Feb 9, 2022 · 5 comments
Labels
bug An existing problem with our app in production

Comments

@longrunningprocess
Copy link
Contributor

Describe the bug
I was recently working with a client who received a generic "Well this is embarrassing..." error during a S/R. I did a little research and finally found the helpful message in the project's .state file that looks like it was intended for the end user. I'm not sure where exactly the message got changed when being returned to the user.

Putting project 'project_name' on hold due to unhandled exception: \nChorus.VcsDrivers.Mercurial.UnrelatedRepositoryErrorException: The repository(a.k.a 'project' or 'collection') that you tried to synchronize with has the same name as yours, but it does not have the same heritage, so it cannot be synchronized. In order to Send/Receive projects, you have to start with a single project/collection, then copy that around. Don't feel bad if this is confusing, just ask for some technical help.

To Reproduce
The real problem was related to some versioning mismatch between the project on LF and the project on Language Depot.

Expected behavior
I would expect the user to receive the message about the "heritage"

Additional context
My research was on a project that is considered sensitive so additional details of my research are captured in email, just ping me for them.

@longrunningprocess longrunningprocess added triage bug An existing problem with our app in production labels Feb 9, 2022
@megahirt
Copy link
Collaborator

C.f. sillsdev/LfMerge#183

@megahirt
Copy link
Collaborator

Yes, this would be a good improvement...

@rmunn
Copy link
Collaborator

rmunn commented Apr 8, 2022

Some (many?) LfMerge errors are not written with the end user in mind, though. But it might be possible to add some code to LfMerge, and/or the LF code that interacts with LfMerge, to filter error messages and pass through a specific list of error messages that are intended for the end user to see.

@rmunn rmunn self-assigned this Jun 16, 2022
@megahirt
Copy link
Collaborator

megahirt commented Sep 6, 2022

This is actually required for the latest LFMerge changes that are being merged into develop.

@megahirt
Copy link
Collaborator

megahirt commented Sep 6, 2022

I anticipate that this issue will be fixed once #1444 is implemented.

@megahirt megahirt closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing problem with our app in production
Projects
Archived in project
Development

No branches or pull requests

4 participants