Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'accumulator' to 'dapol_tree' #127

Closed
Stentonian opened this issue Dec 7, 2023 · 0 comments · Fixed by #148
Closed

Change 'accumulator' to 'dapol_tree' #127

Stentonian opened this issue Dec 7, 2023 · 0 comments · Fixed by #148
Labels
Effort: much Large piece of work enhancement Making the current code better (e.g. performance)

Comments

@Stentonian
Copy link

Stentonian commented Dec 7, 2023

'accumulator' is from the paper but it is not as descriptive as 'dapol_tree'

In the cli the --accumulator flag could possibly be --type

This seems to mirror the paper best:

struct DapolTree {
  accumulator: Accumulator, // enum with values for ndm_smt, dm_smt, etc
  height: Height,
  master_secret: Secret,
  salt_s: Salt,
  salt_b: Salt,
  max_liability: u64, // this should be used for the range proofs: [0, 2^height * max_liability]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: much Large piece of work enhancement Making the current code better (e.g. performance)
Projects
None yet
1 participant