Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not serialize master secret by default #134

Open
Tracked by #135
Stentonian opened this issue Dec 14, 2023 · 3 comments
Open
Tracked by #135

Do not serialize master secret by default #134

Stentonian opened this issue Dec 14, 2023 · 3 comments
Labels
security Important security task
Milestone
Production readiness

Comments

@Stentonian
Copy link

Tree serialization includes the master secret. Since this secret is intended to be created once and used for all PoLs it's best to not include this by default (can have the option to add it).
@Stentonian Stentonian added the security Important security task label Dec 14, 2023
@Stentonian Stentonian added this to the Production readiness milestone Dec 14, 2023
@Stentonian Stentonian mentioned this issue Dec 14, 2023
Open
3 tasks
@Stentonian
Copy link
Author

Also do not print master secret to stdout

@Stentonian
Copy link
Author

Master secret is not printed to stdout anymore, as of #148

@Stentonian
Copy link
Author

Note that removing the secret from the serialized tree will involve partial serializing and then deserializing partial data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security Important security task
Projects
None yet
Milestone
Production readiness
Development

No branches or pull requests
1 participant
@Stentonian