Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master secret & salts #138

Open
Stentonian opened this issue Dec 14, 2023 · 1 comment
Open

Master secret & salts #138

Stentonian opened this issue Dec 14, 2023 · 1 comment
Labels
feature Added functionality to the code security Important security task
Milestone
Production readiness

Comments

@Stentonian
Copy link

Stentonian commented Dec 14, 2023 •
edited
Loading

  • Master secret should never be generated randomly, but should have the option to come from raw input or password input (which will be fed through the KDF to get the master secret)
  • The salts can be generated randomly, or provided
  • A warning should be generated for low-entropy master-secret/salt input
@Stentonian Stentonian added feature Added functionality to the code security Important security task labels Dec 14, 2023
@Stentonian Stentonian added this to the Production readiness milestone Dec 14, 2023
@Stentonian
Copy link
Author

Stentonian commented Jan 16, 2024 •
edited
Loading

Master secret not randomly generated, and salts have option to be generated randomly: #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Added functionality to the code security Important security task
Projects
None yet
Milestone
Production readiness
Development

No branches or pull requests
1 participant
@Stentonian