Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes requested from peer review - updating jest tests #43

Closed
14 tasks done
GuySartorelli opened this issue May 2, 2023 · 0 comments
Closed
14 tasks done

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented May 2, 2023

In peer reviewing silverstripe/silverstripe-admin#1419, there were some changes that were requested but not immediately made, because the mental effort to make the changes at the time was deemed higher than the value of the changes.

In many cases, these sorts of changes are being made going forward - for consistency, correctness, and robustness, it makes sense to tidy up and do them where they were requested as well.

The following changes are important enough that I think they warrant revisiting:

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants