Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot control priority of project files between recipes #12

Open
robbieaverill opened this issue Nov 8, 2018 · 1 comment
Open

Cannot control priority of project files between recipes #12

robbieaverill opened this issue Nov 8, 2018 · 1 comment

Comments

@robbieaverill
Copy link
Contributor

I have a situation where I have two recipe dependencies which both have the same project file:

  • silverstripe/recipe-core: app/_config.php
  • cwp/cwp-recipe-core: app/_config.php

Because app/_config.php from silverstripe/recipe-core is run before pretty much anything else (as a close-to-root dependency), it takes the project file from there and copies it into my project. Subsequent recipes such as cwp/cwp-recipe-core cannot copy their own file after this, because they get ignore as "existing or modified in project."

The problem in this example is really that the file contains password complexity requirements, and because they are then copied into user code they will take priority over everything else. CWP needs to increase the minimum requirements but it can't do so at the moment.

@robbieaverill
Copy link
Contributor Author

FWIW I'm proposing that we remove this project file from recipe-core and move it into YAML configuration instead, which is extensible. This issue could serve as an enhancement request to allow controlling priority between recipes that have the same project files in them though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants