-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate that this module still work and make sure we can replicate the process #55
Comments
First impressions aren't great. Rather than testing directly on SCPS I tried getting docvert running locally in a ubuntu 22 docker container with python 3.10. If I cannot get this running locally then the long term future of using docvert doesn't look great since it would rely on running on ancient versions of things. docvert was developed 9 years ago, when python 3.3 was the current version, rather than 3.10 It has python3-imaging listed as a requirement, which no longer seems to be a thing? It cannot be installed via apt or pip. I think that it was superseded by pillow I tried the following inside my docker container to get requirements sorted: ssh in as root
ssh in as regular www-root user
In another terminal ssh in as www-root
I get the following error
bottle has been included in docvert as a thirdparty library in lib/bottle - however it's not importing for whatever reason Trying to include it via pip:
now yields
I think docvert is probably past its used by date ... |
Can we at least validate what the thing does on SCPS? I think @StephenMakrogianni managed to get it working after a bit of screaming. I'm all for killing the dependency on
Once we know what the expected behaviour is, that will give us a better understanding of how difficult or easy it will be to replicate the feature with a different lib. |
Well yeah it works, sort of. It's pretty rough.
So, probably a handful of .doc features work and lots don't is probably a fair assessment. Presumably switching to a different library would get a larger set of things working I'd say just start again with the new lib |
I created two other cards: The last two ACs still seems relevant:
We can either put this card back into the ready column and pick it back once #58 is done. Or we can close this card and create a new one with the ACs to update cucumber studio. |
This makes sense |
We concluded that getting this working off CWP is too low a priority to justify working on this any further. |
Turns out we don't necessarily have a great process for knowing that this module works well. It looks like it doesn't quite work on SCPS.
Acceptance criteria
We have some instruction for getting a dev environment working for people who don't have docvert-python3 running locally with some sort of mockServiceConnector
.Notes
ServiceConnector
connector withphpoffice/phpword
. So maybe that becomes the mockServiceConnector
.The text was updated successfully, but these errors were encountered: