Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save relations on Link creation instead of parent save #145

Closed
1 task
emteknetnz opened this issue Dec 19, 2023 · 1 comment
Closed
1 task

Save relations on Link creation instead of parent save #145

emteknetnz opened this issue Dec 19, 2023 · 1 comment
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Dec 19, 2023

Currently the has_one relations between Link and parent for both the single and the multi link field are updated when the parent is saved e.g. the page edit form is saved

This can result in a fairly uninuitive situation where orphaned links can be created if the use navigates away from the page without saving. This will get particularly confusing once link sorting has been implemented

Excluded

  • Updating the parent save/published button state - this will be done in another card

Acceptance criteria

  • Link relations are saved to the database on Link creation (modal save) rather than parent save

PRs

@GuySartorelli
Copy link
Member

Merged PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants