JS translations don't seem to get exposed.

[s-kerdel]

Hello,

I am unable to use the TOTP module using dutch translations (nl).
I have the idea the JS lang files aren't exposed / are not detected correctly by the bundle file.
When I add the translations to the MFA module, the translations are detected and visible.

I wonder if the path of the lang files is correct (they say that Translation Tables should be automatically detected).
Maybe something from https://docs.silverstripe.org/en/4/developer_guides/i18n/ might clear things up.

Could you please look into this?
The SS installation is version 4.9.

Acceptance criteria

• Login screen and all MFA screen can be translated and the translation show.
• MFA registration screen in CMS display translation when available

PRs

• FIX Set current locale based on actual defined dictionaries silverstripe-admin#1523
• MNT Add missing translation strings to js src lang #123
• MNT Add missing translation strings to js src lang silverstripe-mfa#497
• MNT Add missing translation strings to js src lang silverstripe-webauthn-authenticator#141

[maxime-rainville]

I had a look at the underlying Dutch translations. The vast majority of the strings in these screenshots have bee translated and should be showing in Dutch ... but they are not.

[RickButer]

I am also having the same issue.
Seems like the translations in de TOTP module are not shown.

[GuySartorelli]

There are a couple of problems at play here.

The first and biggest is that nl is not a valid locale setting to use. i18n is supposed to take 2-character locales and find the appropriate correct-formatted locale for it, but it seems to be failing to do so. The workaround for this is to use nl_NL as your locale, but I'll see what I can do about fixing i18n. Worst case I'll do some documentation to make this clearer.

The second is that some (not many) of the translation strings expected by the js aren't available in the client/lang dir and therefore are never translated. That's a much more minor issue, ultimately, but one that is easy to resolve so I'll resolve it.

[emteknetnz]

@GuySartorelli You've used a POC branch to extract more of the js translations - could you create a new issue for that one explaining the issue and put the POC PR there? As well as the unmerged "MNT Add missing translation strings to js src lang". I'm a bit confused as to why some but not all of the JS translations weren't picked up, I'm not sure if it's restricted to mfa modules or if it's more widespread

[GuySartorelli]

New issue created: silverstripe/silverstripe-framework#10814

[GuySartorelli]

All PRs have been merged and there's no further work to be done. Closing.