Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for window padding #1503

Merged
merged 2 commits into from
Sep 16, 2016
Merged

Added support for window padding #1503

merged 2 commits into from
Sep 16, 2016

Conversation

birjj
Copy link

@birjj birjj commented Sep 9, 2016

As described in #1502.
Added an option called windowPadding, which supports the formats x, "x y z k" and [x, y, z, k], where x, y, z and k are integers. The string and array formats use the normal CSS order (top-right-bottom-left), while the number format applies to all sides.

Fixed JSFiddle.

Image comparisons:

@birjj
Copy link
Author

birjj commented Sep 12, 2016

Updated so it can be merged without conflicts

Copy link
Member

@caseyjhol caseyjhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a useful feature. I'm not sure we need to support the string option, though. Change it to support just a number or array of numbers using a simple if (typeof winPad === 'number') and I should be able to get this merged into the next version.

@birjj
Copy link
Author

birjj commented Sep 16, 2016

Alright, done.

@caseyjhol caseyjhol merged commit d2b8713 into snapappointments:master Sep 16, 2016
@vsn4ik
Copy link
Collaborator

vsn4ik commented Sep 16, 2016

It should be added in documentation.

@caseyjhol
Copy link
Member

Yes, I'll get it added before the official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants