Refactor the ember-cli hooks integration, remove setupResponsiveImage test-helper #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est-helper Now runs as part of `treeForPublic` instead of `postprocessTree` (which is not supported by Embroider). Also changed the way the meta data is accessed, removing the need for initializers, and thus also our test helper.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now runs as part of
treeForPublicinstead ofpostprocessTree(which is not supported by Embroider). Also changed the way the meta data is accessed, removing the need for initializers, and thus also our test helper.This one took me hours here: ember-fastboot/ember-cli-fastboot#807 😔
/cc @andreasschacht @lolmaus