Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase docker image on an Ubuntu image #370

Closed
BrianJKoopman opened this issue Jan 8, 2024 · 1 comment
Closed

Rebase docker image on an Ubuntu image #370

BrianJKoopman opened this issue Jan 8, 2024 · 1 comment
Assignees
@BrianJKoopman
Labels
docker Pull requests that update Docker code enhancement New feature or request

Comments

@BrianJKoopman
Copy link
Member

The OCS docker image is based on simonsobs/so3g, which in turn is based on simonsobs/spt3g, which is based on ubuntu:20.04.

The so3g version isn't actively reflective of the docker image tag, since we also now pip install it, and that pulls in the latest version. So simonsobs/ocs:v0.10.4 actually does have so3g v0.1.10.

The old structure was in place from before so3g was pip installable. We should just drop the use of this structure, and setup ocs directly on the ubuntu:20.04 image. That'll make this easier to maintain and reduce unneeded layers.
@BrianJKoopman BrianJKoopman added enhancement New feature or request docker Pull requests that update Docker code labels Jan 8, 2024
@BrianJKoopman BrianJKoopman self-assigned this Jan 8, 2024
@BrianJKoopman
Copy link
Member Author

Resolved by #397.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianJKoopman BrianJKoopman

Labels
docker Pull requests that update Docker code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BrianJKoopman