Authenticated route: allow easier use w/o mixin #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-north
force-pushed
the
mixout/authenticated-route
branch
from
388bc21
to
ba1eb73
Compare
mike-north
commented
Aug 17, 2018
| * @param {Transition} transition Transition for the user's original navigation | ||
| * @param {(...args: []any) => any} callback Callback that will be invoked if the user is unauthenticated | ||
| */ | ||
| function runIfUnauthenticated(owner, transition, callback) { |
There was a problem hiding this comment.
Once we have more of the simple-auth without mixins (#1619) story in place, we can start to carefully name these functions and export them from their respective modules. For now, we may want to leave these as module-private, and make a single "designing the public API" pass at the end
There was a problem hiding this comment.
yep, I guess that makes sense. That will also probably be the hardest part about this - making sure ESA is still - despite to the relatively large number of things it does now - relatively easy to consume/integrate.
geekygrappler
pushed a commit
to geekygrappler/ember-simple-auth
that referenced
this pull request
Aug 30, 2018
…s mixin into a function - simple the same thing as mainmatter#1655 does for authenticated-route-mixin
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of effort described in #1619
Supercedes #1628