Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps!: SC-13964 Update dependencies #29

Merged
merged 13 commits into from
Aug 29, 2024
Merged

deps!: SC-13964 Update dependencies #29

merged 13 commits into from
Aug 29, 2024

Conversation

alexregier
Copy link
Member

@alexregier alexregier commented Jul 31, 2024 •
edited
Loading

No description provided.

@alexregier alexregier requested review from a team and Sese-Schneider and removed request for a team July 31, 2024 09:27
@alexregier
Copy link
Member Author

@IchordeDionysos any idea on how to fix the node version issue?

@IchordeDionysos
Copy link
Contributor

Not run it on Node 16? 🙈

@alexregier
Copy link
Member Author

@IchordeDionysos can you help out here? I cannot update the node module version in the tsconfig to 18 because that value is not supported. But I want to avoid using commonjs for example.

@IchordeDionysos IchordeDionysos changed the title deps: SC-13964 Update dependencies deps!: SC-13964 Update dependencies Aug 5, 2024
@alexregier
Copy link
Member Author

@IchordeDionysos The tests are complaining about module not being set to node16, but it is set to that value.

@richard-webb-dev
change the jest configs to cjs instead of ts
48b62e2 
ts-jest seems to not be able to process them as a TS ecmascript module - there's an ongoing issue

this isn't ideal, and would also affect any global setup/teardown scripts if they are later added
@richard-webb-dev
deps: update ts-jest version
defd713
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Aug 28, 2024 •
edited
Loading

Coverage Status

coverage: 89.535%. remained the same
when pulling ecbacca on task/SC-13964-update-dependencies
into 7f66dd1 on main.

@richard-webb-dev
Copy link
Contributor

i think it was this issue causing us grief:

kulshekhar/ts-jest#4198

i also considered disabling this option that we were extending from google's tsconfig: https://www.typescriptlang.org/tsconfig/#noEmitOnError
it works, but i'm worried it would mask issues

other alternatives:

  1. stick to TS5.1
  2. move away from ts-jest
  3. use cjs modules

tbh nothing was the perfect answer, but I'm not sure which compromise we want to have here.
I went with an updated typescript, and a funky jest.config.cjs, considering the project is small enough

@richard-webb-dev richard-webb-dev merged commit 938d9ad into main Aug 29, 2024
21 checks passed
@richard-webb-dev richard-webb-dev deleted the task/SC-13964-update-dependencies branch August 29, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-webb-dev richard-webb-dev richard-webb-dev approved these changes

@IchordeDionysos IchordeDionysos IchordeDionysos approved these changes

@Sese-Schneider Sese-Schneider Sese-Schneider approved these changes

@plakhtiin plakhtiin Awaiting requested review from plakhtiin

Assignees

@IchordeDionysos IchordeDionysos

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexregier @IchordeDionysos @richard-webb-dev @Sese-Schneider @plakhtiin