Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid slow file output with JRuby/Windows #16

Merged
merged 2 commits into from
Jul 10, 2014
Merged

Avoid slow file output with JRuby/Windows #16

merged 2 commits into from
Jul 10, 2014

Commits on Jan 21, 2013

  1. Write html output in binary mode 

    JRuby on windows tries to replace all \n with \r\n and does it so poorly that it takes forever to generate the file.
To avoid any kind of interpretation, set the writing mode to wb+ (B meaning binary).
    @pschambacher
    pschambacher committed Jan 21, 2013
    Configuration menu
    Copy the full SHA
    4f6498c View commit details
    Browse the repository at this point in the history

  2. Patch for JRuby/Windows specific to this platform 

    Extract the fix from previous commit into a function.
Only patch for JRuby/Windows. Maybe MRI/Windows is also affected but we would need more input for that.
    @pschambacher
    pschambacher committed Jan 21, 2013
    Configuration menu
    Copy the full SHA
    94884d9 View commit details
    Browse the repository at this point in the history