Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Member list - disallow stashing CONTROLLER #385

Closed
2 tasks
tinola opened this issue Apr 14, 2024 · 3 comments · Fixed by #395
Closed
2 tasks

[Bug]: Member list - disallow stashing CONTROLLER #385

tinola opened this issue Apr 14, 2024 · 3 comments · Fixed by #395
Labels
enhancement New feature or request pinned Does not stale

Comments

@tinola
Copy link
Contributor

tinola commented Apr 14, 2024

🐛 Describe the Bug

Hi,

I think the "STASH" button next to CONTROLLER member should not be shown at all (in popup modal options as well).

BTW, if we have (since v0.6.2) shash button next to every network member, we can delete this button in member options popup modal...

🔍 Steps to Reproduce

🔧 Deployment Type

  • Docker
  • Standalone

✨ Expected Behavior

No response

📋 ZTNET Logs

No response

🖼 Screenshots

No response

@tinola tinola added the bug Something isn't working label Apr 14, 2024
@sinamics
Copy link
Owner

I think the "STASH" button next to CONTROLLER member should not be shown at all.

Why not? The controller is just a client and we should allow to remove it from a network.

BTW, if we have (since v0.6.2) shash button next to every network member, we can delete this button in member options popup modal...

Agree.

@sinamics sinamics added enhancement New feature or request pinned Does not stale and removed bug Something isn't working labels Apr 18, 2024
@tinola
Copy link
Contributor Author

tinola commented Apr 19, 2024

Why not? The controller is just a client and we should allow to remove it from a network.

Basically I haven't tested this. I am not sure whether this will not end in unexpected problems with the network operations when the controller is stashed.

@sinamics
Copy link
Owner

sinamics commented May 8, 2024

Stashing the controller will not affect anything related to the controller side of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Does not stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants