Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Get list of all network addresses used in controller #391

Closed
dsm150 opened this issue May 6, 2024 · 11 comments · Fixed by #394
Closed

[Feature Request]: Get list of all network addresses used in controller #391

dsm150 opened this issue May 6, 2024 · 11 comments · Fixed by #394
Labels
enhancement New feature or request pinned Does not stale

Comments

@dsm150
Copy link

dsm150 commented May 6, 2024

🚀 Feature Summary

Get list of all network addresses used in controller

📝 Detailed Description

As I was able to understand, when creating a new network, the controller does not take into account the addresses of previously created networks, and can create another network with the same address as the existing one.
It would be ideal if each time the controller creates a new network, it would not give out the addresses of the previously created networks.

If this is labor-intensive to implement, it would be sufficient to at least be able to view the list of currently used network addresses.

If there is such a possibility and I have not found it, please help 🙏🏻

🎯 Use Case

No response

💡 Willing to Contribute

None

@dsm150 dsm150 added the enhancement New feature or request label May 6, 2024
@sinamics
Copy link
Owner

sinamics commented May 6, 2024

you are correct. ztnet is selecting a random address when creating network.
one way to solve this is to use the network index and select a address based on that.

Example:

  • Network 1 => 10.121.15.0
  • Network 2 => 10.121.16.0
    ...

@sinamics sinamics added the pinned Does not stale label May 6, 2024
@dsm150
Copy link
Author

dsm150 commented May 6, 2024

That's understandable.
But how to view already issued addresses for existing networks in one list?
When assigning new ones, I would like to see which ones have already been issued.

@sinamics
Copy link
Owner

sinamics commented May 6, 2024

for that we need to store the address in db for each network and then do a lookup to get a list of used addresses.

@dsm150
Copy link
Author

dsm150 commented May 6, 2024

So now the addresses are not stored in the database?
If they are, how can I query the database?
It would be great if clicking on "Total networks" would display a list of networks and their addresses.
iScreen Shoter - Yandex - 240506211104

@sinamics
Copy link
Owner

sinamics commented May 6, 2024

network ip is not stored in db.

model network {

@dsm150
Copy link
Author

dsm150 commented May 6, 2024

At the moment, to find out the addresses of all networks, you have to manually go through each network and write in notepad...
With hundreds of networks, this will become impossible....

Is it possible to do something about this in the future?

@sinamics
Copy link
Owner

sinamics commented May 6, 2024

Yes, i will add a list of used ip`s in the controller page and the "Ip Assignment" section for each network.
Another nice feature would be to inform users that X network uses the same address as a notification.

@dsm150
Copy link
Author

dsm150 commented May 6, 2024

Looking forward to the update. It will be excellent!

@sinamics
Copy link
Owner

sinamics commented May 8, 2024

@dsm150 would this be sufficient enough?

image

@sinamics
Copy link
Owner

sinamics commented May 9, 2024

merged these changes.
I will add more notifications in the network ip assignement section later on when i get time.

@dsm150
Copy link
Author

dsm150 commented May 14, 2024

@dsm150 would this be sufficient enough?

This is already good, but yes, it would be much more convenient if a unique range was generated when creating a new network, or if you could select a range given the existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Does not stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants