Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-error-definition rule does not validate against exported name #190

Closed
MrHen opened this issue Sep 3, 2018 · 2 comments · Fixed by #313
Closed

custom-error-definition rule does not validate against exported name #190

MrHen opened this issue Sep 3, 2018 · 2 comments · Fixed by #313
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@MrHen
Copy link
Contributor

MrHen commented Sep 3, 2018

Issuehunt badges

The following passes linting:

exports.fooError = class FooError extends Error {
    constructor(error) {
        super(error);
        this.name = 'FooError';
    }
};

The name used in exports.fooError should match the name used in this.name = 'FooError';.

A commented out test was added as part of #188 to cover this scenario.


IssueHunt Summary

mrhen mrhen has been rewarded.

Sponsors (Total: $40.00)

Tips

@sindresorhus sindresorhus changed the title custom-error-definition does not validate against exported name custom-error-definition rule does not validate against exported name Sep 3, 2018
@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 31, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jun 10, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @MrHen. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants