Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities detected with decompress #342

Closed
oguilleux opened this issue Feb 27, 2020 · 5 comments
Closed

Vulnerabilities detected with decompress #342

oguilleux opened this issue Feb 27, 2020 · 5 comments

Comments

@oguilleux
Copy link

Hi there, there seems to be a vulnerability with a dependency :

Arbitrary File Write with Package "decompress"
Path : gulp-imagemin > imagemin-optipng > optipng-bin > bin-wrapper > download > decompress
Path : gulp-imagemin > imagemin-mozjpeg > mozjpeg > bin-wrapper > download > decompress
Path : gulp-imagemin > imagemin-gifsicle > gifsicle > bin-wrapper > download > decompress
Path : gulp-imagemin > imagemin-optipng > optipng-bin > bin-build > download > decompress
Path : gulp-imagemin > imagemin-mozjpeg > mozjpeg > bin-build > download > decompress
Path : gulp-imagemin > imagemin-gifsicle > gifsicle > bin-build > download > decompress
Path : gulp-imagemin > imagemin-optipng > optipng-bin > bin-build > decompress
Path : gulp-imagemin > imagemin-mozjpeg > mozjpeg > bin-build > decompress
Path : gulp-imagemin > imagemin-gifsicle > gifsicle > bin-build > decompress
More info : https://npmjs.com/advisories/1217

Thanks for your work !

@Ionaru
Copy link

Ionaru commented Feb 27, 2020

Decompress has a PR in-progress: kevva/decompress#73

@colorful-tones
Copy link

decompress just merged a fix for this: kevva/decompress#73 (comment)

@colorful-tones
Copy link

I'm just now realizing that @sindresorhus merged fix for decompress and is a maintainer of gulp-imagemin . 🤦‍♂

Thanks for all the great work Sindre! 👏

@colorful-tones
Copy link

@sindresorhus is it a matter of waiting for imagemin to pull in the update. And then gulp-imagemin can pull in that latest from imagemin for this?

I'm not clear as to where decompress comes in to the dependency tree here.

@tjbulick
Copy link
Contributor

tjbulick commented Apr 3, 2020

@colorful-tones decompress doesn't come into dependency tree of this package directly. It comes as a part of underlying packages. If we want this package to pull those security updates, then we need to have them in each package of dependency tree chain first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants