Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortQueryParameters buggy handling of search parameters #189

Open
nomagick opened this issue Jun 20, 2024 · 0 comments
Open

sortQueryParameters buggy handling of search parameters #189

nomagick opened this issue Jun 20, 2024 · 0 comments

Comments

@nomagick
Copy link

normalize-url/index.js

Lines 245 to 248 in 4869023

// Calling `.sort()` encodes the search parameters, so we need to decode them again.
try {
urlObject.search = decodeURIComponent(urlObject.search);
} catch {}

When the query string contains %2F or / like in some S3 signed token, the extra decodeURIComponent breaks the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant