Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract StdinDiscarder into separate library #143

Closed
ffMathy opened this issue Mar 30, 2020 · 7 comments
Closed

Extract StdinDiscarder into separate library #143

ffMathy opened this issue Mar 30, 2020 · 7 comments

Comments

@ffMathy
Copy link

ffMathy commented Mar 30, 2020

It would be super useful to use separately.

@sindresorhus
Copy link
Owner

// @stroncium

@stroncium
Copy link
Contributor

stroncium commented Mar 30, 2020

Yeah, no prob. Though probably on coming weekend, have to make money for now 😢.

@Richienb
Copy link

Richienb commented May 5, 2020

@sindresorhus To speed up the completion of this issue, I'll extract the code if you wish.

@sindresorhus
Copy link
Owner

I would prefer if @stroncium did it as he's the one with the most experience about all the edge-cases.

@stroncium
Copy link
Contributor

Yeah, that sounds like a good idea, that thing can be quite tricky. Sorry for delay, a lot of irl stuff happening. I'll get to it asap.

@sindresorhus
Copy link
Owner

@stroncium I have now extracted it to a separate package: https://github.com/sindresorhus/stdin-discarder

However, I noticed some things:

@stroncium
Copy link
Contributor

I will look into it, but at the time of fix it was clearly working. Probably have to do with some undocumented details of node(which I had some fair fights with working on this thing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants